Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • G g1
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 68
    • Issues 68
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 4
    • Merge requests 4
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • cto
  • g1
  • Issues
  • #98

Closed
Open
Created Sep 24, 2018 by Pratap Vardhan@pratap.vardhanMaintainer

formhandler error handling broken

Summary

If there are errors in querying, formhandler doesn't handle the error. Looks like a regression bug from 0.9.0

Steps to reproduce

Setup with g1 0.9.1

<div class="formhandler" data-src="nonexisting-url"></div>
<!-- libraries -->
<script>
$('.formhandler').formhandler()
</script>

What is the current bug behavior?

Formhandler doesn't make any changes to dom. This probably happens for any error handling, on fresh/reloading the page/component.

What is the expected correct behavior?

It should render error template into .note, BUT, .note is not present in the dom.

Possible fixes

No-so cleaner way.

  • If you don't want to render other components.
  • Check if el = $('.note', $this) -- el.length exists else use el = $this for el.html(message)

--

Edited Sep 24, 2018 by Pratap Vardhan
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking