cto issueshttps://code.gramener.com/groups/cto/-/issues2018-08-13T09:19:08Zhttps://code.gramener.com/cto/g1/-/issues/59[Mapviewer] Feature request - After the zoom text should be visible2018-08-13T09:19:08ZAnvesh Dasari[Mapviewer] Feature request - After the zoom text should be visible![image](/uploads/d521bfe1d616ed18beaadc0467354ae2/image.png)
When we do the zoom on the map text should be visible.![image](/uploads/d521bfe1d616ed18beaadc0467354ae2/image.png)
When we do the zoom on the map text should be visible.1.40TejeshTejeshhttps://code.gramener.com/cto/g1/-/issues/54[Mapviewer] Feature request - Filter regions based on click events2018-08-13T09:22:53ZAnvesh Dasari[Mapviewer] Feature request - Filter regions based on click eventsUttar Pradesh map
![uttar-pradesh](/uploads/006272c52a62c3d8e6ce533bde1bf55c/uttar-pradesh.PNG)
On clicking a region, highlight the clicked region
![uttar-pradesh-filtered](/uploads/78389e3367a7ada13055df1ffd2f87bb/uttar-pradesh-filte...Uttar Pradesh map
![uttar-pradesh](/uploads/006272c52a62c3d8e6ce533bde1bf55c/uttar-pradesh.PNG)
On clicking a region, highlight the clicked region
![uttar-pradesh-filtered](/uploads/78389e3367a7ada13055df1ffd2f87bb/uttar-pradesh-filtered.PNG)1.40TejeshTejeshhttps://code.gramener.com/cto/g1/-/issues/62FormHandler table code review2018-08-28T08:14:53ZS AnandFormHandler table code review- Code corrections
- [x] Do not use encodeURIComponent to escape selectors. Use quotes instead. Remove quotes if they exist in the name
- [x] Do we need to check for `if (dirty_td.length > 0) {`
- [x] `options.edit.editFunction()` ...- Code corrections
- [x] Do not use encodeURIComponent to escape selectors. Use quotes instead. Remove quotes if they exist in the name
- [x] Do we need to check for `if (dirty_td.length > 0) {`
- [x] `options.edit.editFunction()` should probably be `options.edit.editFunction` -- and should probably be `edit.function`. Also call editFunction on `.done()` if it is defined. Not via `complete:`. Always use promises
- [x] `if (options[name] == 'grid') name = 'table_grid'` is duplicated
- [x] Rename `compile_template()` to `render_template()` and document it
- Documentation
- [x] Add row needs documentation
- [x] Actions are poorly explained
- [x] Add example of how to use icon function
- Usability
- [ ] If the server responds with a Bad Request, show the actual error message
- [x] When using keyboard navigation, changed inputs are not detected as dirty
- [x] Loading indicator is not visible
- [ ] Simulate server / network failure and test. If data is lost, user should be aware
- [x] After adding a row and saving, the row should remain where it was added (i.e. at the top of the table)
- [x] All functions must accept a single object with these names (unless it's impossible.)
- `data`: the dataset from `src`
- `row`: row data - dict of {name: value}
- `index`: row index
- `name`: column name
- `value`: cell data value
- `link`: cell link value
- `format`: formatted cell display value
- [x] How can a developer add a delete button simply?
- Feature enhancements
- [x] Icon URLs are static. They must be based on the row data -- as a string template or function1.40TejeshTejesh