Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • G g1
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 68
    • Issues 68
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 4
    • Merge requests 4
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • cto
  • g1
  • Issues
  • #92

Closed
Open
Created Aug 23, 2018 by S Anand@s.anandOwner7 of 13 tasks completed7/13 tasks

FormHandler Table: master issue

These were tested on g1 0.9.0 using this configuration:

url:
  formhandler:
    pattern: /users
    handler: FormHandler
    kwargs:
      url: users.xlsx
      id: user
  • If a table has few rows, allow column dropdown to go below page. Currently it gets chopped off

image

  • After delete action, the row is not deleted in the UI, but it is deleted in the backend. Reloading the page refreshes and shows that the row has been deleted.

  • In case of an error on the AJAX submission (e.g. a delete action, add action, etc), there error message clears the table. Instead, the error message should be shown above the table. Ideally, this should be a re-usable function. Other custom actions should be able to just call .alert(msg) and re-use the same alerting mechanism

  • If $.formhandler does not find jQuery, Bootstrap, etc, show a visible one-time dismissable warning that can be turned off by default

  • Allow exporting as JSON, CSV (in addition to XLSX). This helps users right-click and copy-paste the URL into applications.

proxy

  • Deleting an empty primary key in Excel deletes all rows.

proxy

  • If all rows in table are deleted, we cannot add rows. Maybe because it loses information on what columns exist.

proxy

  • Make Add and Edit easier. On Add / Edit:

    • move focus to first input $('input', ...).focus(). I want to directly start typing
    • give me a cancel option in red .btn-danger
    • make the Save button green .btn-success
    • don't allow both add and edit to happen at the same time
    • allow shortcut (Enter) to save
  • [ ]

Edited Apr 09, 2019 by Tejesh
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking