Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • G g1
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 68
    • Issues 68
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 4
    • Merge requests 4
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • cto
  • g1
  • Issues
  • #62

Closed
Open
Created Jun 18, 2018 by S Anand@s.anandOwner14 of 16 tasks completed14/16 tasks

FormHandler table code review

  • Code corrections

    • Do not use encodeURIComponent to escape selectors. Use quotes instead. Remove quotes if they exist in the name
    • Do we need to check for if (dirty_td.length > 0) {
    • options.edit.editFunction() should probably be options.edit.editFunction -- and should probably be edit.function. Also call editFunction on .done() if it is defined. Not via complete:. Always use promises
    • if (options[name] == 'grid') name = 'table_grid' is duplicated
    • Rename compile_template() to render_template() and document it
  • Documentation

    • Add row needs documentation
    • Actions are poorly explained
    • Add example of how to use icon function
  • Usability

    • If the server responds with a Bad Request, show the actual error message
    • When using keyboard navigation, changed inputs are not detected as dirty
    • Loading indicator is not visible
    • Simulate server / network failure and test. If data is lost, user should be aware
    • After adding a row and saving, the row should remain where it was added (i.e. at the top of the table)
    • All functions must accept a single object with these names (unless it's impossible.)
      • data: the dataset from src
      • row: row data - dict of {name: value}
      • index: row index
      • name: column name
      • value: cell data value
      • link: cell link value
      • format: formatted cell display value
    • How can a developer add a delete button simply?
  • Feature enhancements

    • Icon URLs are static. They must be based on the row data -- as a string template or function
Edited Jul 18, 2018 by Tejesh
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking