Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
G
g1
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 76
    • Issues 76
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 4
    • Merge Requests 4
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • cto
  • g1
  • Issues
  • #173

Closed
Open
Opened Jun 21, 2019 by Tejesh@tejesh.p🖖Maintainer
  • Report abuse
  • New issue
Report abuse New issue

Move g1.formhandler table , g1.mapviewer modules into separate repos

We want to break up g1 into independent repositories. This will popularize g1 components because:

  • People prefer libraries with a single purpose
  • They are more likely to use it (and contribute back) since the learning curve is less

Approach:

  • mapviewer: mapviewer.js, leaflet-utils.js
  • urlfilter: url.js, urlfilter.js, urlchange.js, ajaxchain.js
  • some template library: template.js
  • sanddance: sanddance.js
  • g1: Gramex specific components:
    • datafilter.js
    • formhandler.js
    • translate.js
  • ... and other components which we may re-package later
    • dropdown.js
    • scale.js
    • types.js
    • highlight.js
    • search.js
    • fuzzysearch.js
    • TODO: Find out how to handle dependencies, e.g. event.js.

Note: g1 will continue to import these libraries and function as before -- fully backward compatible.

Approach for mapviewer

  • Create a repo: github.com/gramener/mapviewer
  • Create an npm package called mapviewer via this repo. This should export an ES6 module (src/mapviewer.js) and UMD module (dist/mapviewer.js) via package.json
  • Migrate test cases
  • Refactor g1 to use import the mapviewer package as an ES6 module
Edited Jun 26, 2019 by S Anand
To upload designs, you'll need to enable LFS and have admin enable hashed storage. More information
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: cto/g1#173