g1 issueshttps://code.gramener.com/cto/g1/-/issues2019-02-27T06:09:46Zhttps://code.gramener.com/cto/g1/-/issues/146FormHandler table should support search in columns, like in excel2019-02-27T06:09:46ZBhanu Kbhanu.kamapantula@gramener.comFormHandler table should support search in columns, like in excelapart from filtering via unique values (#142) columns in table should support inline searchapart from filtering via unique values (#142) columns in table should support inline search1.51TejeshTejeshhttps://code.gramener.com/cto/g1/-/issues/142g1.formhandler table must show unique items in header dropdown for quick filt...2019-02-27T06:09:46ZTejeshg1.formhandler table must show unique items in header dropdown for quick filtering, like Excel![image](/uploads/27d5c68392f0b1d6c6f2ed40f7a55da5/image.png)
raised by @sindhura.ch for bmgf admin panel
Table only with sort minus filters & dropdowns![image](/uploads/27d5c68392f0b1d6c6f2ed40f7a55da5/image.png)
raised by @sindhura.ch for bmgf admin panel
Table only with sort minus filters & dropdowns1.51TejeshTejeshhttps://code.gramener.com/cto/g1/-/issues/83Equals not working in column dropdown in FormHandler table2019-02-27T06:09:46ZNaveen ManukondaEquals not working in column dropdown in FormHandler table- When we search with equals in first page it is working good.
- When we click on second page equals as we had only one search result again we need to click on first page for getting the result. If we have only one search result can we r...- When we search with equals in first page it is working good.
- When we click on second page equals as we had only one search result again we need to click on first page for getting the result. If we have only one search result can we redirect to 1 page in the table.
- Can we clear the filters without updating the URL?
- Please refer to below gif.![formhabdler_table](/uploads/7ae8c6e09d5ba35a3e0918a04e47f17e/formhabdler_table.gif)1.51TejeshTejeshhttps://code.gramener.com/cto/g1/-/issues/82Create a dropdown component for filters2019-06-28T06:54:49ZS AnandCreate a dropdown component for filters- [x] Create a $.dropdown() that supports basic dropdown capability
- [x] Extend for multi-select
- [ ] Integrate with FilterHandler for multiple filters
- [ ] Integrate with FilterHandler for heirarchical filters- [x] Create a $.dropdown() that supports basic dropdown capability
- [x] Extend for multi-select
- [ ] Integrate with FilterHandler for multiple filters
- [ ] Integrate with FilterHandler for heirarchical filters1.51https://code.gramener.com/cto/g1/-/issues/53FormHandler Table - Feature to disable column options2019-02-05T10:18:58ZBhanu Kbhanu.kamapantula@gramener.comFormHandler Table - Feature to disable column optionsCurrently, column options are enabled by default
![fh-table-column-options](/uploads/951039e00889a78d3dafbce5132e1f2d/fh-table-column-options.png)
It would be good to have an option to disable it.Currently, column options are enabled by default
![fh-table-column-options](/uploads/951039e00889a78d3dafbce5132e1f2d/fh-table-column-options.png)
It would be good to have an option to disable it.1.51TejeshTejeshhttps://code.gramener.com/cto/g1/-/issues/150g1.formhandler - pick rows for edits2019-02-12T18:10:57ZTejeshg1.formhandler - pick rows for editscurrently edit mode highlights all rows for editing, this is slow on DOM and will be taxing for users with limited hardware configuration
a) if we add selectpicker class for a select element in edit mode, it takes forever and blocks an...currently edit mode highlights all rows for editing, this is slow on DOM and will be taxing for users with limited hardware configuration
a) if we add selectpicker class for a select element in edit mode, it takes forever and blocks any further browsing as it applies for all rows. ex: we've 4 select elements in a row and 300 odd rows.
raised by @bhanu.k1.52TejeshTejeshhttps://code.gramener.com/cto/g1/-/issues/129g1.urlfilter does not work for checkboxes2020-06-22T08:16:39ZTejeshg1.urlfilter does not work for checkboxes```html
<li class="state_dropdown" filter-name="state_level" data-val="Odisha">
<label class="custom-control custom-checkbox h5 mb-0 text-nowrap cursor-pointer">
<input type="checkbox" class="custom-control-input urlfilter" d...```html
<li class="state_dropdown" filter-name="state_level" data-val="Odisha">
<label class="custom-control custom-checkbox h5 mb-0 text-nowrap cursor-pointer">
<input type="checkbox" class="custom-control-input urlfilter" data-mode="toggle" data-target="#" checked>
<span class="custom-control-label"></span>
<span class="custom-control-description sm2">Odisha</span>
</label>
</li>
```
is expected to update url and also, toggle the state of checkbox. It does neither.
g1.urlfilter's `e.preventDefault` intrudes bootstrap checkbox events.
Possible solutions:
Apply preventDefault only for anchor tags.
```js
if(e.target.tagName.toLowerCase() === 'a') {
e.preventDefault()
}
```
raised by @naveen.manukonda1.52TejeshTejesh2019-07-31https://code.gramener.com/cto/g1/-/issues/152data-target='pushState' not working as expected in g1 0.14.02019-04-23T03:47:52ZNaveen Manukondadata-target='pushState' not working as expected in g1 0.14.0```html
<div class="d-md-flex justify-content-md-between custom-w-1">
<div class="align-self-end">
<ul class="nav h1 mb-0 border-success border border-top-0 border-left-0 border-right-0">
<li class="nav-item ">
<a class=...```html
<div class="d-md-flex justify-content-md-between custom-w-1">
<div class="align-self-end">
<ul class="nav h1 mb-0 border-success border border-top-0 border-left-0 border-right-0">
<li class="nav-item ">
<a class="nav-link active urlfilter sm4 pb-2 text-secondary font-weight-bold pl-0 border-secondary border border-top-0 border-left-0 border-right-0 border-2" href="?view=summary" data-target="pushState">Summary <span class="d-block"> View</span></a>
</li>
<li class="nav-item">
<a class="nav-link sm4 pb-2 text-success font-weight-bold pr-0 urlfilter" href="?view=comparative" data-target="pushState"><span class="comparative-tab">Comparative</span> <span class="d-block"> View</span></a>
</li>
</ul>
</div>
</div>
```
When we click on Comparative View my page is reloading in latest **g1** version(0.14.0), Expected: Page reload must not happen because `data-target="pushState"`
It is working fine in **g1** version(0.13.1)1.54TejeshTejeshhttps://code.gramener.com/cto/g1/-/issues/162G1.datafilter does not filter undefined values2019-04-20T13:59:22ZTejeshG1.datafilter does not filter undefined values1.55TejeshTejeshhttps://code.gramener.com/cto/g1/-/issues/176add a new row with empty data for g1.formhandler2019-12-05T11:15:48ZPratap Vardhanpratap.vardhan@gramener.comadd a new row with empty data for g1.formhandler### Summary
We can't add a new row with empty data for g1.formhandler
### Steps to reproduce
- Create a csv with columns alone and hook it up with formhandler### Summary
We can't add a new row with empty data for g1.formhandler
### Steps to reproduce
- Create a csv with columns alone and hook it up with formhandlerhttps://code.gramener.com/cto/g1/-/issues/175FormHandler filters are not working with multiple tables in a single page2020-02-04T07:11:19ZBharat Rbharath.r@gramener.comFormHandler filters are not working with multiple tables in a single page**FormHandler filters are not working with multiple tables in a single page**
- When applying filters to one table it is applying to all tables by default
- And namespaces are applying only when the namespace is coming from the URL
**S...**FormHandler filters are not working with multiple tables in a single page**
- When applying filters to one table it is applying to all tables by default
- And namespaces are applying only when the namespace is coming from the URL
**Suggested FIX:**
- When a `namespace` is given to table any filter in the url should apply along with the `namespace`
For Ex.
```
$('.fh_table').formHandler({
namespace: 'name'
})
```
The url for the filters of the above snippet should be `?name:key=value`Bharat Rbharath.r@gramener.comBharat Rbharath.r@gramener.comhttps://code.gramener.com/cto/g1/-/issues/174g1.formhandler editable table to support multi-select in dropdowns2019-07-31T08:51:03ZTejeshg1.formhandler editable table to support multi-select in dropdownsExpose option for more low level spec to support various third-party dropdown components.Expose option for more low level spec to support various third-party dropdown components.https://code.gramener.com/cto/g1/-/issues/173Move g1.formhandler table , g1.mapviewer modules into separate repos2019-06-26T01:52:32ZTejeshMove g1.formhandler table , g1.mapviewer modules into separate reposWe want to break up g1 into independent repositories. This will popularize g1 components because:
- People prefer libraries with a single purpose
- They are more likely to use it (and contribute back) since the learning curve is less
A...We want to break up g1 into independent repositories. This will popularize g1 components because:
- People prefer libraries with a single purpose
- They are more likely to use it (and contribute back) since the learning curve is less
Approach:
- `mapviewer`: mapviewer.js, leaflet-utils.js
- `urlfilter`: url.js, urlfilter.js, urlchange.js, ajaxchain.js
- `some template library`: template.js
- `sanddance`: sanddance.js
- `g1`: Gramex specific components:
- datafilter.js
- formhandler.js
- translate.js
- ... and other components which we may re-package later
- dropdown.js
- scale.js
- types.js
- highlight.js
- search.js
- fuzzysearch.js
- TODO: Find out how to handle dependencies, e.g. event.js.
Note: g1 will continue to import these libraries and function as before -- fully backward compatible.
### Approach for mapviewer
- Create a repo: github.com/gramener/mapviewer
- Create an npm package called [mapviewer](https://www.npmjs.com/package/mapviewer) via this repo. This should export an ES6 module (src/mapviewer.js) and UMD module (dist/mapviewer.js) via package.json
- Migrate test cases
- Refactor g1 to use import the mapviewer package as an ES6 module
https://code.gramener.com/cto/g1/-/issues/170Async sub-templates fail sometimes2019-06-04T04:23:11ZS AnandAsync sub-templates fail sometimes@tejesh.p please see https://code.gramener.com/cto/g1/-/jobs/115982
The test case related to "$().template() loaded static async sub templates" fails -- though it passes sometimes (on the server).
Maybe because we're checking before th...@tejesh.p please see https://code.gramener.com/cto/g1/-/jobs/115982
The test case related to "$().template() loaded static async sub templates" fails -- though it passes sometimes (on the server).
Maybe because we're checking before the sub-template has loaded? Could you please explore the test case?TejeshTejeshhttps://code.gramener.com/cto/g1/-/issues/167G1.formhandler editable table not working for radio/checkbox type input elements2019-05-09T10:21:26ZJPjaiprakash.siyyadri@gramener.comG1.formhandler editable table not working for radio/checkbox type input elementsPossible solutions:
Wrap all editable input elements inside a `<form>` tagPossible solutions:
Wrap all editable input elements inside a `<form>` tagTejeshTejeshhttps://code.gramener.com/cto/g1/-/issues/166FormHandler Export downloading2019-05-02T08:10:54ZJPjaiprakash.siyyadri@gramener.comFormHandler Export downloadingThe export option should download the data in the same column order as we are showing in the table with title as column namesThe export option should download the data in the same column order as we are showing in the table with title as column namesTejeshTejeshhttps://code.gramener.com/cto/g1/-/issues/165FormHandler input checkbox option is not working2019-05-02T06:06:28ZJPjaiprakash.siyyadri@gramener.comFormHandler input checkbox option is not workingThe requirement is to edit and show column data, which has yes or no values, as input type checkbox.
If it is yes the option should be checked else uncheckedThe requirement is to edit and show column data, which has yes or no values, as input type checkbox.
If it is yes the option should be checked else uncheckedhttps://code.gramener.com/cto/g1/-/issues/164Unable to deselect the selected sorted option2019-05-08T02:28:37ZAkash BarlaUnable to deselect the selected sorted option![sort_deselect](/uploads/a7bd6a42973c618f863c80da2cc68eb5/sort_deselect.gif)![sort_deselect](/uploads/a7bd6a42973c618f863c80da2cc68eb5/sort_deselect.gif)TejeshTejeshhttps://code.gramener.com/cto/g1/-/issues/163Column filter is displaying multiple times in header when we hide the filter2019-05-08T02:28:28ZAkash BarlaColumn filter is displaying multiple times in header when we hide the filter![Column_hiding_issue](/uploads/5876b231e885375373c38129a3ed27fe/Column_hiding_issue.gif)![Column_hiding_issue](/uploads/5876b231e885375373c38129a3ed27fe/Column_hiding_issue.gif)TejeshTejeshhttps://code.gramener.com/cto/g1/-/issues/161g1.formhandler refactor2019-05-08T02:28:20ZTejeshg1.formhandler refactor1. define hierarchy of hooks, make sure it is consistent
2. Examples & documentation
3. Refactor to develop faster1. define hierarchy of hooks, make sure it is consistent
2. Examples & documentation
3. Refactor to develop fasterTejeshTejesh