g1 issueshttps://code.gramener.com/cto/g1/-/issues2019-02-16T04:54:14Zhttps://code.gramener.com/cto/g1/-/issues/119urlchange usage patterns2019-02-16T04:54:14ZPratap Vardhanpratap.vardhan@gramener.comurlchange usage patterns# 1
Currently only single key change is supported `?key=only`
I'd like to capture events for when multiple keys have changed
```
#?key-one&key-two -- AND
#?key-one|key-two -- OR can be handled with chained .on().on()
```
# 2
When ...# 1
Currently only single key change is supported `?key=only`
I'd like to capture events for when multiple keys have changed
```
#?key-one&key-two -- AND
#?key-one|key-two -- OR can be handled with chained .on().on()
```
# 2
When key is removed hash or entirely removed to `#?`, event is not trigger.
This would help to detect reset mode.
# 3
Document how to reset url state to home hash.1.51Karmanya AggarwalKarmanya Aggarwalhttps://code.gramener.com/cto/g1/-/issues/120FormHandler usecases for documentation examples2019-02-05T10:15:17ZPratap Vardhanpratap.vardhan@gramener.comFormHandler usecases for documentation examplesShow examples for
- Have access to fetched data
Show examples for
- Have access to fetched data
1.51TejeshTejeshhttps://code.gramener.com/cto/g1/-/issues/121g1.dropdown documentation notes2019-02-02T14:40:04ZPratap Vardhanpratap.vardhan@gramener.comg1.dropdown documentation notes# 1
In a page with `g1.dropdown({ key: 'drop', ... })`, if user open a url with `#?drop=value1`, show code snippet that shows the default dropdown value as `value1`# 1
In a page with `g1.dropdown({ key: 'drop', ... })`, if user open a url with `#?drop=value1`, show code snippet that shows the default dropdown value as `value1`https://code.gramener.com/cto/g1/-/issues/122Mapviewer: add removeLayer abstract function2019-02-02T14:38:24ZTejeshMapviewer: add removeLayer abstract functionmap.removeLayer('layerName') must remove 'layerName' layer from map....map.removeLayer('layerName') must remove 'layerName' layer from map....Bharat Rbharath.r@gramener.comBharat Rbharath.r@gramener.comhttps://code.gramener.com/cto/g1/-/issues/123formhandler - don't allow both add and edit to happen at the same time2019-01-14T11:28:09ZTejeshformhandler - don't allow both add and edit to happen at the same timeSindhura CHSindhura CHhttps://code.gramener.com/cto/g1/-/issues/126Templates should only update changed elements via virtualdom2019-01-04T12:20:52ZS AnandTemplates should only update changed elements via virtualdomThis allows:
- Smooth animation via CSS style updates
- Lower CPU utilization
- Faster DOM updatesThis allows:
- Smooth animation via CSS style updates
- Lower CPU utilization
- Faster DOM updates1.49S AnandS Anandhttps://code.gramener.com/cto/g1/-/issues/127g1.formhandler calls render on window hashchange event, document usage on SPAs2019-02-07T03:59:08ZPratap Vardhanpratap.vardhan@gramener.comg1.formhandler calls render on window hashchange event, document usage on SPAsOn SPAs, when you rerender the view/formhandler, events attached `$(window).on('hashchange', render)` will still exist. This results in N+1 xhr requests made for data.
What should be recommended/cleaner way to destroy previously attach...On SPAs, when you rerender the view/formhandler, events attached `$(window).on('hashchange', render)` will still exist. This results in N+1 xhr requests made for data.
What should be recommended/cleaner way to destroy previously attached events?1.51Pratap Vardhanpratap.vardhan@gramener.comPratap Vardhanpratap.vardhan@gramener.comhttps://code.gramener.com/cto/g1/-/issues/128Add urlchange event to path changes2019-01-11T15:03:06ZPratap Vardhanpratap.vardhan@gramener.comAdd urlchange event to path changesCurrently, `urlchange` detects query changes, would like to detect path changes as well
`#/path1/sub1/?q=1` -> `#/path2/sub2/?q=1`
```javascript
$(window).urlchange()
.on('#/', ... })
```
Also, add a note in the documentation about ...Currently, `urlchange` detects query changes, would like to detect path changes as well
`#/path1/sub1/?q=1` -> `#/path2/sub2/?q=1`
```javascript
$(window).urlchange()
.on('#/', ... })
```
Also, add a note in the documentation about when history changes and when it does not, and how this interacts with the back button.1.49S AnandS Anandhttps://code.gramener.com/cto/g1/-/issues/130g1 compatible Browser Version list2019-01-12T11:43:07ZSundeep Reddy Mallug1 compatible Browser Version list### Summary
Evaluate and publish list of compatible Browser version for g1
### Benefits
Establish clear line of communication from Sales, Marketing material and project teams on the compatible browser versions. This will ensure custome...### Summary
Evaluate and publish list of compatible Browser version for g1
### Benefits
Establish clear line of communication from Sales, Marketing material and project teams on the compatible browser versions. This will ensure customers don't have negative experience while using the Data Apps built on top of Gramex.
### Usage
Establish browser version that should be part of our delivery commitment
- Chrome
- Firefox
- Safari
- Microsoft Edge
Perform this action every-time g1 release is pushed.1.49S AnandS Anandhttps://code.gramener.com/cto/g1/-/issues/131FormHandler add does not show dropdowns while FormHandler edit does2019-01-25T08:13:24ZS AnandFormHandler add does not show dropdowns while FormHandler edit doesRaised by @sindhura.ch
When using a select for specific columns (see code below):
```yaml
columns: [
{ name: '*' },
{
name: 'user_designation',
editable: {
input: 'select',
...Raised by @sindhura.ch
When using a select for specific columns (see code below):
```yaml
columns: [
{ name: '*' },
{
name: 'user_designation',
editable: {
input: 'select',
options: ['ACMO', 'CDO']
}
},
{ name: 'user_password', hide: true },
{ name: 'actions', template: $('#action-template').html() }
]
```
... the dropdown is visible when we click **Edit** but not when we click **Add**. See screenshots below.
![image](/uploads/b7a550001240a215be070f84c5692499/image.png)
![image](/uploads/794eb9caf9244ff28351c9617fa2c8e0/image.png)TejeshTejeshhttps://code.gramener.com/cto/g1/-/issues/132g1 $search configurable example documentation2022-11-07T09:16:17ZSundeep Reddy Mallug1 $search configurable example documentationg1 $search documentation released as part of 1.49 only points to fuzzy match feature. This issue calls out the need to extend the search capability by configuration (to accommodate additional logic) and share more examples.g1 $search documentation released as part of 1.49 only points to fuzzy match feature. This issue calls out the need to extend the search capability by configuration (to accommodate additional logic) and share more examples.S AnandS Anandhttps://code.gramener.com/cto/g1/-/issues/133g1.formhandler link:false in a column should disable the link,2019-03-15T05:50:41ZTejeshg1.formhandler link:false in a column should disable the link,* Disable all controls* Disable all controlsS AnandS Anandhttps://code.gramener.com/cto/g1/-/issues/134Backlink g1 release notes from Gramex releases2019-02-03T03:58:58ZBhanu Kbhanu.kamapantula@gramener.comBacklink g1 release notes from Gramex releases### Summary
currently `g1` release notes ship with `Gramex` release notes. Example: [v1.47 notes](https://learn.gramener.com/guide/release/1.47/#g1)
in `g1` repository, changes are visible in [CHANGELOG](https://code.gramener.com/cto/g...### Summary
currently `g1` release notes ship with `Gramex` release notes. Example: [v1.47 notes](https://learn.gramener.com/guide/release/1.47/#g1)
in `g1` repository, changes are visible in [CHANGELOG](https://code.gramener.com/cto/g1/blob/master/CHANGELOG.md). This isn't easy to spot.
Perhaps [v1.47 notes](https://learn.gramener.com/guide/release/1.47/#g1) can be linked in a `Releases` section.
### Benefits
Developers, OSS communityhttps://code.gramener.com/cto/g1/-/issues/137G1.types is not available as a separate module2019-01-25T07:41:04ZTejeshG1.types is not available as a separate moduleTejeshTejeshhttps://code.gramener.com/cto/g1/-/issues/139g1.types doesn't detect dates2019-01-24T16:51:32ZPratap Vardhanpratap.vardhan@gramener.comg1.types doesn't detect datesAs per [g1.types docs](https://code.gramener.com/cto/g1/blob/master/docs/types.md#g1types), column `d` should have been `date` but it detected as `string`. Would like to detect below as `date`.
```javascript
var data = [
{a: 1, b: 1.1...As per [g1.types docs](https://code.gramener.com/cto/g1/blob/master/docs/types.md#g1types), column `d` should have been `date` but it detected as `string`. Would like to detect below as `date`.
```javascript
var data = [
{a: 1, b: 1.1, c: 'c', d: '2014-04-04', e: true},
{a: 2, b: 2},
]
g1.types(data)
{a: "number", b: "number", c: "string", d: "string", e: "boolean"}
```
Although, this works with `options = {convert: true}`
```jaavscript
g1.types(data, {convert: true})
{a: "number", b: "number", c: "string", d: "date", e: "boolean"}
```
If this is intended, please update the documentation? S AnandS Anandhttps://code.gramener.com/cto/g1/-/issues/140g1.formhandler should clear all filters2019-02-07T03:59:35ZPratap Vardhanpratap.vardhan@gramener.comg1.formhandler should clear all filtersWhen the multiple `?a=1&a=2` query parameters with same keys are passed, `Clear All` filters doesn't remove all filters.When the multiple `?a=1&a=2` query parameters with same keys are passed, `Clear All` filters doesn't remove all filters.1.51TejeshTejeshhttps://code.gramener.com/cto/g1/-/issues/141g1.types detects strings ending with space and then number as dates (not stri...2022-11-07T09:16:25ZTejeshg1.types detects strings ending with space and then number as dates (not strings)when you pass strings that end with space and number, when using `{convert: true}`.
```javascript
g1.types([{NAME: "Gramex 1"}], {convert: true})
{NAME: "date"}
```
Issue is with how `Date.parse` behaves.
```
Date.parse('Gramex 1')
978...when you pass strings that end with space and number, when using `{convert: true}`.
```javascript
g1.types([{NAME: "Gramex 1"}], {convert: true})
{NAME: "date"}
```
Issue is with how `Date.parse` behaves.
```
Date.parse('Gramex 1')
978287400000
```
raised by @pratap.vardhanS AnandS Anandhttps://code.gramener.com/cto/g1/-/issues/143BUG: Save after adding new row does not add data to source2019-01-30T06:58:52ZTejeshBUG: Save after adding new row does not add data to source1.50TejeshTejeshhttps://code.gramener.com/cto/g1/-/issues/145g1.mapviewer.js and g1.min.js are conflicting due to same namespace2019-02-04T11:13:34ZTejeshg1.mapviewer.js and g1.min.js are conflicting due to same namespace1.51TejeshTejeshhttps://code.gramener.com/cto/g1/-/issues/147g1 and mapviewer is not working together since gramex 1.502019-02-15T05:05:09ZMohammed Niyasg1 and mapviewer is not working together since gramex 1.50### Summary
g1 and mapviewer is not working together since gramex version 1.50
### Steps to reproduce
1. Import g1
2. Import mapviewer
3. Try accessing g1 (eg: g1.url.parse(location.href)). This throws error
Otherwise
1. Import mapvi...### Summary
g1 and mapviewer is not working together since gramex version 1.50
### Steps to reproduce
1. Import g1
2. Import mapviewer
3. Try accessing g1 (eg: g1.url.parse(location.href)). This throws error
Otherwise
1. Import mapviewer
2. Import g1
3. Now g1.mapviewer is not callable
### What is the expected *correct* behavior?
Both should work irrespective of import order
If required, @sharabh.singhi Can help to reproduce this.