g1 issueshttps://code.gramener.com/cto/g1/-/issues2019-02-04T10:05:08Zhttps://code.gramener.com/cto/g1/-/issues/19Find and add a loading indicator component2019-02-04T10:05:08ZS AnandFind and add a loading indicator componenthttps://code.gramener.com/cto/g1/-/issues/123formhandler - don't allow both add and edit to happen at the same time2019-01-14T11:28:09ZTejeshformhandler - don't allow both add and edit to happen at the same timeSindhura CHSindhura CHhttps://code.gramener.com/cto/g1/-/issues/155Formhandler - show _count, _limit, _offset also as filters.2019-03-04T03:51:04ZTejeshFormhandler - show _count, _limit, _offset also as filters.On changing pageSize, there is no way to clear the filter. Showing `_limit=` also in filters will help.
Same problem when applied filter `"Europe"`, goto page 2 and clear `"Europe"` filter.....Still shows _offset=1, no way to clear the ...On changing pageSize, there is no way to clear the filter. Showing `_limit=` also in filters will help.
Same problem when applied filter `"Europe"`, goto page 2 and clear `"Europe"` filter.....Still shows _offset=1, no way to clear the filter.
Other solution is to, On click of "clear all filters", remove `_offset=`https://code.gramener.com/cto/g1/-/issues/131FormHandler add does not show dropdowns while FormHandler edit does2019-01-25T08:13:24ZS AnandFormHandler add does not show dropdowns while FormHandler edit doesRaised by @sindhura.ch
When using a select for specific columns (see code below):
```yaml
columns: [
{ name: '*' },
{
name: 'user_designation',
editable: {
input: 'select',
...Raised by @sindhura.ch
When using a select for specific columns (see code below):
```yaml
columns: [
{ name: '*' },
{
name: 'user_designation',
editable: {
input: 'select',
options: ['ACMO', 'CDO']
}
},
{ name: 'user_password', hide: true },
{ name: 'actions', template: $('#action-template').html() }
]
```
... the dropdown is visible when we click **Edit** but not when we click **Add**. See screenshots below.
![image](/uploads/b7a550001240a215be070f84c5692499/image.png)
![image](/uploads/794eb9caf9244ff28351c9617fa2c8e0/image.png)TejeshTejeshhttps://code.gramener.com/cto/g1/-/issues/20FormHandler cell click can link to an external page / event2018-05-24T16:16:25ZS AnandFormHandler cell click can link to an external page / eventTejeshTejeshhttps://code.gramener.com/cto/g1/-/issues/23FormHandler enhancements2018-04-11T12:29:06ZSundeep Reddy MalluFormHandler enhancements### Summary
Enhance g1 library to enhance FormHandler usage
- [x] FormHandler table coloring and Formatting -- handled by #37
- [x] Formhandler table namespacing -- tracking in #28
- [ ] Formhandler table slider### Summary
Enhance g1 library to enhance FormHandler usage
- [x] FormHandler table coloring and Formatting -- handled by #37
- [x] Formhandler table namespacing -- tracking in #28
- [ ] Formhandler table sliderAbinesh LalAbinesh Lalhttps://code.gramener.com/cto/g1/-/issues/98formhandler error handling broken2018-10-14T04:43:26ZPratap Vardhanpratap.vardhan@gramener.comformhandler error handling broken### Summary
If there are errors in querying, formhandler doesn't handle the error. Looks like a regression bug from 0.9.0
### Steps to reproduce
Setup with g1 0.9.1
```html
<div class="formhandler" data-src="nonexisting-url"></div>
<...### Summary
If there are errors in querying, formhandler doesn't handle the error. Looks like a regression bug from 0.9.0
### Steps to reproduce
Setup with g1 0.9.1
```html
<div class="formhandler" data-src="nonexisting-url"></div>
<!-- libraries -->
<script>
$('.formhandler').formhandler()
</script>
```
### What is the current *bug* behavior?
Formhandler doesn't make any changes to dom. This probably happens for any error handling, on fresh/reloading the page/component.
### What is the expected *correct* behavior?
It should render error template into `.note`, BUT, `.note` is not present in the dom.
### Possible fixes
No-so cleaner way.
- If you don't want to render other components.
- Check if `el = $('.note', $this)` -- `el.length` exists else use `el = $this` for `el.html(message)`
--TejeshTejeshhttps://code.gramener.com/cto/g1/-/issues/157Formhandler Excel export options must enable downloading of entire dataset2019-03-12T05:50:13ZTejeshFormhandler Excel export options must enable downloading of entire datasetraised by @anvesh.dasariraised by @anvesh.dasarihttps://code.gramener.com/cto/g1/-/issues/166FormHandler Export downloading2019-05-02T08:10:54ZJPjaiprakash.siyyadri@gramener.comFormHandler Export downloadingThe export option should download the data in the same column order as we are showing in the table with title as column namesThe export option should download the data in the same column order as we are showing in the table with title as column namesTejeshTejeshhttps://code.gramener.com/cto/g1/-/issues/175FormHandler filters are not working with multiple tables in a single page2020-02-04T07:11:19ZBharat Rbharath.r@gramener.comFormHandler filters are not working with multiple tables in a single page**FormHandler filters are not working with multiple tables in a single page**
- When applying filters to one table it is applying to all tables by default
- And namespaces are applying only when the namespace is coming from the URL
**S...**FormHandler filters are not working with multiple tables in a single page**
- When applying filters to one table it is applying to all tables by default
- And namespaces are applying only when the namespace is coming from the URL
**Suggested FIX:**
- When a `namespace` is given to table any filter in the url should apply along with the `namespace`
For Ex.
```
$('.fh_table').formHandler({
namespace: 'name'
})
```
The url for the filters of the above snippet should be `?name:key=value`Bharat Rbharath.r@gramener.comBharat Rbharath.r@gramener.comhttps://code.gramener.com/cto/g1/-/issues/165FormHandler input checkbox option is not working2019-05-02T06:06:28ZJPjaiprakash.siyyadri@gramener.comFormHandler input checkbox option is not workingThe requirement is to edit and show column data, which has yes or no values, as input type checkbox.
If it is yes the option should be checked else uncheckedThe requirement is to edit and show column data, which has yes or no values, as input type checkbox.
If it is yes the option should be checked else uncheckedhttps://code.gramener.com/cto/g1/-/issues/28Formhandler namespaces with multiple formhandlers2018-05-24T16:16:25ZTejeshFormhandler namespaces with multiple formhandlers### Summary
Formhandler namespaces with multiple formhandlers
### Benefits
Lets developers apply url filter on multiple datasets
### Usage
Apart from `src`, developers can mention `name` option while defining formhandler.
### Exam...### Summary
Formhandler namespaces with multiple formhandlers
### Benefits
Lets developers apply url filter on multiple datasets
### Usage
Apart from `src`, developers can mention `name` option while defining formhandler.
### Example:
?fh1_name:Name=Andorra&fh2_name:Continent=Europe1.33TejeshTejeshhttps://code.gramener.com/cto/g1/-/issues/79Formhandler Plugin mechanism - Datacomb2018-07-16T11:23:46ZTejeshFormhandler Plugin mechanism - DatacombPlugin Mixin to include functionality easily at almost any level.
To start with https://github.com/cmpolis/datacombPlugin Mixin to include functionality easily at almost any level.
To start with https://github.com/cmpolis/datacombhttps://code.gramener.com/cto/g1/-/issues/71formhandler should support groupby2022-11-07T09:15:53ZPratap Vardhanpratap.vardhan@gramener.comformhandler should support groupby### Summary
Gramex FormHandler now supports `_by`. See gramex#401
For GET requests, `?_by=State&_by=City` does the following:
- Group by State and City (in that order)
- Show sum of all numeric columns
- Show count of all non-numeric ...### Summary
Gramex FormHandler now supports `_by`. See gramex#401
For GET requests, `?_by=State&_by=City` does the following:
- Group by State and City (in that order)
- Show sum of all numeric columns
- Show count of all non-numeric columns (including date columns)
We need following options in formhandler table
- In column dropdowns to select that column has groupby key.
- Ability to hide certain aggregate columns
- Change aggregation type of the column
- Placeholder alongside pagination to list down dimensions and metrics.
### Benefits
This will allow users to create self-service explorations with formhandler interface.S AnandS Anandhttps://code.gramener.com/cto/g1/-/issues/38Formhandler Table - Add/Delete new rows2018-04-16T09:47:05ZTejeshFormhandler Table - Add/Delete new rows### Summary
Formhandler table to support adding new rows to the table
### Benefits
Admin module - Add new user feature if done using this feature, will be a single line of configuration.
### Usage
```js
$('.formhandler').formhandler(...### Summary
Formhandler table to support adding new rows to the table
### Benefits
Admin module - Add new user feature if done using this feature, will be a single line of configuration.
### Usage
```js
$('.formhandler').formhandler({
src: ....,
...
...
addRow: true / false(default )
})
```TejeshTejeshhttps://code.gramener.com/cto/g1/-/issues/53FormHandler Table - Feature to disable column options2019-02-05T10:18:58ZBhanu Kbhanu.kamapantula@gramener.comFormHandler Table - Feature to disable column optionsCurrently, column options are enabled by default
![fh-table-column-options](/uploads/951039e00889a78d3dafbce5132e1f2d/fh-table-column-options.png)
It would be good to have an option to disable it.Currently, column options are enabled by default
![fh-table-column-options](/uploads/951039e00889a78d3dafbce5132e1f2d/fh-table-column-options.png)
It would be good to have an option to disable it.1.51TejeshTejeshhttps://code.gramener.com/cto/g1/-/issues/42formhandler table cell link is not urlencoded2019-03-01T04:00:22ZTejeshformhandler table cell link is not urlencoded### Summary
formhandler table cell link is not urlencoded
### Steps to reproduce
g1 version 0.6.0
visit https://uat.gramener.com/fdd/#?SEGMENT=M%26M and click on Segment column value `M&M`. Filtering fails because `&` in `M&M` is not...### Summary
formhandler table cell link is not urlencoded
### Steps to reproduce
g1 version 0.6.0
visit https://uat.gramener.com/fdd/#?SEGMENT=M%26M and click on Segment column value `M&M`. Filtering fails because `&` in `M&M` is not urlencoded
### Possible fixes
Need to add a test case and verify the issue. Expected behavior of current code is urlencoded string but that's not the case.1.51S AnandS Anandhttps://code.gramener.com/cto/g1/-/issues/62FormHandler table code review2018-08-28T08:14:53ZS AnandFormHandler table code review- Code corrections
- [x] Do not use encodeURIComponent to escape selectors. Use quotes instead. Remove quotes if they exist in the name
- [x] Do we need to check for `if (dirty_td.length > 0) {`
- [x] `options.edit.editFunction()` ...- Code corrections
- [x] Do not use encodeURIComponent to escape selectors. Use quotes instead. Remove quotes if they exist in the name
- [x] Do we need to check for `if (dirty_td.length > 0) {`
- [x] `options.edit.editFunction()` should probably be `options.edit.editFunction` -- and should probably be `edit.function`. Also call editFunction on `.done()` if it is defined. Not via `complete:`. Always use promises
- [x] `if (options[name] == 'grid') name = 'table_grid'` is duplicated
- [x] Rename `compile_template()` to `render_template()` and document it
- Documentation
- [x] Add row needs documentation
- [x] Actions are poorly explained
- [x] Add example of how to use icon function
- Usability
- [ ] If the server responds with a Bad Request, show the actual error message
- [x] When using keyboard navigation, changed inputs are not detected as dirty
- [x] Loading indicator is not visible
- [ ] Simulate server / network failure and test. If data is lost, user should be aware
- [x] After adding a row and saving, the row should remain where it was added (i.e. at the top of the table)
- [x] All functions must accept a single object with these names (unless it's impossible.)
- `data`: the dataset from `src`
- `row`: row data - dict of {name: value}
- `index`: row index
- `name`: column name
- `value`: cell data value
- `link`: cell link value
- `format`: formatted cell display value
- [x] How can a developer add a delete button simply?
- Feature enhancements
- [x] Icon URLs are static. They must be based on the row data -- as a string template or function1.40TejeshTejeshhttps://code.gramener.com/cto/g1/-/issues/109formhandler table copy/pasteFromClipboard feature2018-11-14T11:37:46ZTejeshformhandler table copy/pasteFromClipboard featureTejeshTejeshhttps://code.gramener.com/cto/g1/-/issues/57formhandler table modal doesnot appear sometimes (needs page refresh to make ...2018-07-16T11:28:23ZTejeshformhandler table modal doesnot appear sometimes (needs page refresh to make it work)TejeshTejesh