g1 issueshttps://code.gramener.com/cto/g1/-/issues2019-02-27T06:09:46Zhttps://code.gramener.com/cto/g1/-/issues/142g1.formhandler table must show unique items in header dropdown for quick filt...2019-02-27T06:09:46ZTejeshg1.formhandler table must show unique items in header dropdown for quick filtering, like Excel![image](/uploads/27d5c68392f0b1d6c6f2ed40f7a55da5/image.png)
raised by @sindhura.ch for bmgf admin panel
Table only with sort minus filters & dropdowns![image](/uploads/27d5c68392f0b1d6c6f2ed40f7a55da5/image.png)
raised by @sindhura.ch for bmgf admin panel
Table only with sort minus filters & dropdowns1.51TejeshTejeshhttps://code.gramener.com/cto/g1/-/issues/140g1.formhandler should clear all filters2019-02-07T03:59:35ZPratap Vardhanpratap.vardhan@gramener.comg1.formhandler should clear all filtersWhen the multiple `?a=1&a=2` query parameters with same keys are passed, `Clear All` filters doesn't remove all filters.When the multiple `?a=1&a=2` query parameters with same keys are passed, `Clear All` filters doesn't remove all filters.1.51TejeshTejeshhttps://code.gramener.com/cto/g1/-/issues/127g1.formhandler calls render on window hashchange event, document usage on SPAs2019-02-07T03:59:08ZPratap Vardhanpratap.vardhan@gramener.comg1.formhandler calls render on window hashchange event, document usage on SPAsOn SPAs, when you rerender the view/formhandler, events attached `$(window).on('hashchange', render)` will still exist. This results in N+1 xhr requests made for data.
What should be recommended/cleaner way to destroy previously attach...On SPAs, when you rerender the view/formhandler, events attached `$(window).on('hashchange', render)` will still exist. This results in N+1 xhr requests made for data.
What should be recommended/cleaner way to destroy previously attached events?1.51Pratap Vardhanpratap.vardhan@gramener.comPratap Vardhanpratap.vardhan@gramener.comhttps://code.gramener.com/cto/g1/-/issues/120FormHandler usecases for documentation examples2019-02-05T10:15:17ZPratap Vardhanpratap.vardhan@gramener.comFormHandler usecases for documentation examplesShow examples for
- Have access to fetched data
Show examples for
- Have access to fetched data
1.51TejeshTejeshhttps://code.gramener.com/cto/g1/-/issues/119urlchange usage patterns2019-02-16T04:54:14ZPratap Vardhanpratap.vardhan@gramener.comurlchange usage patterns# 1
Currently only single key change is supported `?key=only`
I'd like to capture events for when multiple keys have changed
```
#?key-one&key-two -- AND
#?key-one|key-two -- OR can be handled with chained .on().on()
```
# 2
When ...# 1
Currently only single key change is supported `?key=only`
I'd like to capture events for when multiple keys have changed
```
#?key-one&key-two -- AND
#?key-one|key-two -- OR can be handled with chained .on().on()
```
# 2
When key is removed hash or entirely removed to `#?`, event is not trigger.
This would help to detect reset mode.
# 3
Document how to reset url state to home hash.1.51Karmanya AggarwalKarmanya Aggarwalhttps://code.gramener.com/cto/g1/-/issues/105G1 UrlFilter interactive documentation2019-02-15T07:30:21ZTejeshG1 UrlFilter interactive documentationTejesh to merge work done by @jaiprakash.siyyadri
@sundeep.mallu could you please suggest priority on releasing this part of 1.45?
cc: @s.anandTejesh to merge work done by @jaiprakash.siyyadri
@sundeep.mallu could you please suggest priority on releasing this part of 1.45?
cc: @s.anand1.51S AnandS Anandhttps://code.gramener.com/cto/g1/-/issues/83Equals not working in column dropdown in FormHandler table2019-02-27T06:09:46ZNaveen ManukondaEquals not working in column dropdown in FormHandler table- When we search with equals in first page it is working good.
- When we click on second page equals as we had only one search result again we need to click on first page for getting the result. If we have only one search result can we r...- When we search with equals in first page it is working good.
- When we click on second page equals as we had only one search result again we need to click on first page for getting the result. If we have only one search result can we redirect to 1 page in the table.
- Can we clear the filters without updating the URL?
- Please refer to below gif.![formhabdler_table](/uploads/7ae8c6e09d5ba35a3e0918a04e47f17e/formhabdler_table.gif)1.51TejeshTejeshhttps://code.gramener.com/cto/g1/-/issues/82Create a dropdown component for filters2019-06-28T06:54:49ZS AnandCreate a dropdown component for filters- [x] Create a $.dropdown() that supports basic dropdown capability
- [x] Extend for multi-select
- [ ] Integrate with FilterHandler for multiple filters
- [ ] Integrate with FilterHandler for heirarchical filters- [x] Create a $.dropdown() that supports basic dropdown capability
- [x] Extend for multi-select
- [ ] Integrate with FilterHandler for multiple filters
- [ ] Integrate with FilterHandler for heirarchical filters1.51https://code.gramener.com/cto/g1/-/issues/53FormHandler Table - Feature to disable column options2019-02-05T10:18:58ZBhanu Kbhanu.kamapantula@gramener.comFormHandler Table - Feature to disable column optionsCurrently, column options are enabled by default
![fh-table-column-options](/uploads/951039e00889a78d3dafbce5132e1f2d/fh-table-column-options.png)
It would be good to have an option to disable it.Currently, column options are enabled by default
![fh-table-column-options](/uploads/951039e00889a78d3dafbce5132e1f2d/fh-table-column-options.png)
It would be good to have an option to disable it.1.51TejeshTejeshhttps://code.gramener.com/cto/g1/-/issues/42formhandler table cell link is not urlencoded2019-03-01T04:00:22ZTejeshformhandler table cell link is not urlencoded### Summary
formhandler table cell link is not urlencoded
### Steps to reproduce
g1 version 0.6.0
visit https://uat.gramener.com/fdd/#?SEGMENT=M%26M and click on Segment column value `M&M`. Filtering fails because `&` in `M&M` is not...### Summary
formhandler table cell link is not urlencoded
### Steps to reproduce
g1 version 0.6.0
visit https://uat.gramener.com/fdd/#?SEGMENT=M%26M and click on Segment column value `M&M`. Filtering fails because `&` in `M&M` is not urlencoded
### Possible fixes
Need to add a test case and verify the issue. Expected behavior of current code is urlencoded string but that's not the case.1.51S AnandS Anandhttps://code.gramener.com/cto/g1/-/issues/150g1.formhandler - pick rows for edits2019-02-12T18:10:57ZTejeshg1.formhandler - pick rows for editscurrently edit mode highlights all rows for editing, this is slow on DOM and will be taxing for users with limited hardware configuration
a) if we add selectpicker class for a select element in edit mode, it takes forever and blocks an...currently edit mode highlights all rows for editing, this is slow on DOM and will be taxing for users with limited hardware configuration
a) if we add selectpicker class for a select element in edit mode, it takes forever and blocks any further browsing as it applies for all rows. ex: we've 4 select elements in a row and 300 odd rows.
raised by @bhanu.k1.52TejeshTejeshhttps://code.gramener.com/cto/g1/-/issues/129g1.urlfilter does not work for checkboxes2020-06-22T08:16:39ZTejeshg1.urlfilter does not work for checkboxes```html
<li class="state_dropdown" filter-name="state_level" data-val="Odisha">
<label class="custom-control custom-checkbox h5 mb-0 text-nowrap cursor-pointer">
<input type="checkbox" class="custom-control-input urlfilter" d...```html
<li class="state_dropdown" filter-name="state_level" data-val="Odisha">
<label class="custom-control custom-checkbox h5 mb-0 text-nowrap cursor-pointer">
<input type="checkbox" class="custom-control-input urlfilter" data-mode="toggle" data-target="#" checked>
<span class="custom-control-label"></span>
<span class="custom-control-description sm2">Odisha</span>
</label>
</li>
```
is expected to update url and also, toggle the state of checkbox. It does neither.
g1.urlfilter's `e.preventDefault` intrudes bootstrap checkbox events.
Possible solutions:
Apply preventDefault only for anchor tags.
```js
if(e.target.tagName.toLowerCase() === 'a') {
e.preventDefault()
}
```
raised by @naveen.manukonda1.52TejeshTejesh2019-07-31https://code.gramener.com/cto/g1/-/issues/85FormHandler table should support client-side validation2019-02-27T06:35:44ZS AnandFormHandler table should support client-side validationRaised by @sarad.gurram and @bhanu.k - "Client-side HTML input validation while editing"Raised by @sarad.gurram and @bhanu.k - "Client-side HTML input validation while editing"1.52S AnandS Anandhttps://code.gramener.com/cto/g1/-/issues/75formhandler: should support multiple sort2019-02-25T12:57:25ZPratap Vardhanpratap.vardhan@gramener.comformhandler: should support multiple sort### Summary
Currently, from the interface, user can select only column to sort on. However Gramex FormHandler supports multiple column sort by Column order.
For example, this https://learn.gramener.com/guide/formhandler/table.html#?_so...### Summary
Currently, from the interface, user can select only column to sort on. However Gramex FormHandler supports multiple column sort by Column order.
For example, this https://learn.gramener.com/guide/formhandler/table.html#?_sort=Continent&_sort=Name
- Would show two column sort on Name, Continent
- although it doesn't highlight the columns.
- If you try to add or modify existing sort. It get's replaced by single sort.
We would need a way to support muli-column sort, if we also want to support toggle between columns for single sort.1.52Pratap Vardhanpratap.vardhan@gramener.comPratap Vardhanpratap.vardhan@gramener.comhttps://code.gramener.com/cto/g1/-/issues/156BUG: In editable formhandler, select tag doesnt take default values if src da...2019-03-17T02:45:25ZTejeshBUG: In editable formhandler, select tag doesnt take default values if src data contains boolean values1.53TejeshTejeshhttps://code.gramener.com/cto/g1/-/issues/152data-target='pushState' not working as expected in g1 0.14.02019-04-23T03:47:52ZNaveen Manukondadata-target='pushState' not working as expected in g1 0.14.0```html
<div class="d-md-flex justify-content-md-between custom-w-1">
<div class="align-self-end">
<ul class="nav h1 mb-0 border-success border border-top-0 border-left-0 border-right-0">
<li class="nav-item ">
<a class=...```html
<div class="d-md-flex justify-content-md-between custom-w-1">
<div class="align-self-end">
<ul class="nav h1 mb-0 border-success border border-top-0 border-left-0 border-right-0">
<li class="nav-item ">
<a class="nav-link active urlfilter sm4 pb-2 text-secondary font-weight-bold pl-0 border-secondary border border-top-0 border-left-0 border-right-0 border-2" href="?view=summary" data-target="pushState">Summary <span class="d-block"> View</span></a>
</li>
<li class="nav-item">
<a class="nav-link sm4 pb-2 text-success font-weight-bold pr-0 urlfilter" href="?view=comparative" data-target="pushState"><span class="comparative-tab">Comparative</span> <span class="d-block"> View</span></a>
</li>
</ul>
</div>
</div>
```
When we click on Comparative View my page is reloading in latest **g1** version(0.14.0), Expected: Page reload must not happen because `data-target="pushState"`
It is working fine in **g1** version(0.13.1)1.54TejeshTejeshhttps://code.gramener.com/cto/g1/-/issues/162G1.datafilter does not filter undefined values2019-04-20T13:59:22ZTejeshG1.datafilter does not filter undefined values1.55TejeshTejeshhttps://code.gramener.com/cto/g1/-/issues/169Template should allow access to source node2019-05-28T09:37:21ZS AnandTemplate should allow access to source nodeTemplates should support additional variables:
- `$this` accesses the jQuery template variable
- `$data` is a shortcut for `$this.data()`Templates should support additional variables:
- `$this` accesses the jQuery template variable
- `$data` is a shortcut for `$this.data()`1.56S AnandS Anandhttps://code.gramener.com/cto/g1/-/issues/176add a new row with empty data for g1.formhandler2019-12-05T11:15:48ZPratap Vardhanpratap.vardhan@gramener.comadd a new row with empty data for g1.formhandler### Summary
We can't add a new row with empty data for g1.formhandler
### Steps to reproduce
- Create a csv with columns alone and hook it up with formhandler### Summary
We can't add a new row with empty data for g1.formhandler
### Steps to reproduce
- Create a csv with columns alone and hook it up with formhandlerhttps://code.gramener.com/cto/g1/-/issues/175FormHandler filters are not working with multiple tables in a single page2020-02-04T07:11:19ZBharat Rbharath.r@gramener.comFormHandler filters are not working with multiple tables in a single page**FormHandler filters are not working with multiple tables in a single page**
- When applying filters to one table it is applying to all tables by default
- And namespaces are applying only when the namespace is coming from the URL
**S...**FormHandler filters are not working with multiple tables in a single page**
- When applying filters to one table it is applying to all tables by default
- And namespaces are applying only when the namespace is coming from the URL
**Suggested FIX:**
- When a `namespace` is given to table any filter in the url should apply along with the `namespace`
For Ex.
```
$('.fh_table').formHandler({
namespace: 'name'
})
```
The url for the filters of the above snippet should be `?name:key=value`Bharat Rbharath.r@gramener.comBharat Rbharath.r@gramener.com