g1 issueshttps://code.gramener.com/cto/g1/-/issues2018-08-28T08:14:53Zhttps://code.gramener.com/cto/g1/-/issues/62FormHandler table code review2018-08-28T08:14:53ZS AnandFormHandler table code review- Code corrections
- [x] Do not use encodeURIComponent to escape selectors. Use quotes instead. Remove quotes if they exist in the name
- [x] Do we need to check for `if (dirty_td.length > 0) {`
- [x] `options.edit.editFunction()` ...- Code corrections
- [x] Do not use encodeURIComponent to escape selectors. Use quotes instead. Remove quotes if they exist in the name
- [x] Do we need to check for `if (dirty_td.length > 0) {`
- [x] `options.edit.editFunction()` should probably be `options.edit.editFunction` -- and should probably be `edit.function`. Also call editFunction on `.done()` if it is defined. Not via `complete:`. Always use promises
- [x] `if (options[name] == 'grid') name = 'table_grid'` is duplicated
- [x] Rename `compile_template()` to `render_template()` and document it
- Documentation
- [x] Add row needs documentation
- [x] Actions are poorly explained
- [x] Add example of how to use icon function
- Usability
- [ ] If the server responds with a Bad Request, show the actual error message
- [x] When using keyboard navigation, changed inputs are not detected as dirty
- [x] Loading indicator is not visible
- [ ] Simulate server / network failure and test. If data is lost, user should be aware
- [x] After adding a row and saving, the row should remain where it was added (i.e. at the top of the table)
- [x] All functions must accept a single object with these names (unless it's impossible.)
- `data`: the dataset from `src`
- `row`: row data - dict of {name: value}
- `index`: row index
- `name`: column name
- `value`: cell data value
- `link`: cell link value
- `format`: formatted cell display value
- [x] How can a developer add a delete button simply?
- Feature enhancements
- [x] Icon URLs are static. They must be based on the row data -- as a string template or function1.40TejeshTejeshhttps://code.gramener.com/cto/g1/-/issues/104g1.formhandler Editable table must render appropriate UI elements for corresp...2018-11-14T11:33:32ZTejeshg1.formhandler Editable table must render appropriate UI elements for corresponding data TypeUsecase:
* [x] dropdown in FormHandler table for use in the admin page. This will allow developers to specify a pre-defined list of roles users can pick from.
Will start with dropdown support and extend for
* [x] DatePicker
* [x] ...Usecase:
* [x] dropdown in FormHandler table for use in the admin page. This will allow developers to specify a pre-defined list of roles users can pick from.
Will start with dropdown support and extend for
* [x] DatePicker
* [x] restricted number type input element (Min, Max, etc)1.45TejeshTejeshhttps://code.gramener.com/cto/g1/-/issues/148$.formhandler editable fails for columns which have spaces in name2019-02-15T05:56:30ZTejesh$.formhandler editable fails for columns which have spaces in nameraised by @venkata.reddyraised by @venkata.reddy1.51TejeshTejeshhttps://code.gramener.com/cto/g1/-/issues/146FormHandler table should support search in columns, like in excel2019-02-27T06:09:46ZBhanu Kbhanu.kamapantula@gramener.comFormHandler table should support search in columns, like in excelapart from filtering via unique values (#142) columns in table should support inline searchapart from filtering via unique values (#142) columns in table should support inline search1.51TejeshTejeshhttps://code.gramener.com/cto/g1/-/issues/142g1.formhandler table must show unique items in header dropdown for quick filt...2019-02-27T06:09:46ZTejeshg1.formhandler table must show unique items in header dropdown for quick filtering, like Excel![image](/uploads/27d5c68392f0b1d6c6f2ed40f7a55da5/image.png)
raised by @sindhura.ch for bmgf admin panel
Table only with sort minus filters & dropdowns![image](/uploads/27d5c68392f0b1d6c6f2ed40f7a55da5/image.png)
raised by @sindhura.ch for bmgf admin panel
Table only with sort minus filters & dropdowns1.51TejeshTejeshhttps://code.gramener.com/cto/g1/-/issues/127g1.formhandler calls render on window hashchange event, document usage on SPAs2019-02-07T03:59:08ZPratap Vardhanpratap.vardhan@gramener.comg1.formhandler calls render on window hashchange event, document usage on SPAsOn SPAs, when you rerender the view/formhandler, events attached `$(window).on('hashchange', render)` will still exist. This results in N+1 xhr requests made for data.
What should be recommended/cleaner way to destroy previously attach...On SPAs, when you rerender the view/formhandler, events attached `$(window).on('hashchange', render)` will still exist. This results in N+1 xhr requests made for data.
What should be recommended/cleaner way to destroy previously attached events?1.51Pratap Vardhanpratap.vardhan@gramener.comPratap Vardhanpratap.vardhan@gramener.comhttps://code.gramener.com/cto/g1/-/issues/120FormHandler usecases for documentation examples2019-02-05T10:15:17ZPratap Vardhanpratap.vardhan@gramener.comFormHandler usecases for documentation examplesShow examples for
- Have access to fetched data
Show examples for
- Have access to fetched data
1.51TejeshTejeshhttps://code.gramener.com/cto/g1/-/issues/83Equals not working in column dropdown in FormHandler table2019-02-27T06:09:46ZNaveen ManukondaEquals not working in column dropdown in FormHandler table- When we search with equals in first page it is working good.
- When we click on second page equals as we had only one search result again we need to click on first page for getting the result. If we have only one search result can we r...- When we search with equals in first page it is working good.
- When we click on second page equals as we had only one search result again we need to click on first page for getting the result. If we have only one search result can we redirect to 1 page in the table.
- Can we clear the filters without updating the URL?
- Please refer to below gif.![formhabdler_table](/uploads/7ae8c6e09d5ba35a3e0918a04e47f17e/formhabdler_table.gif)1.51TejeshTejeshhttps://code.gramener.com/cto/g1/-/issues/53FormHandler Table - Feature to disable column options2019-02-05T10:18:58ZBhanu Kbhanu.kamapantula@gramener.comFormHandler Table - Feature to disable column optionsCurrently, column options are enabled by default
![fh-table-column-options](/uploads/951039e00889a78d3dafbce5132e1f2d/fh-table-column-options.png)
It would be good to have an option to disable it.Currently, column options are enabled by default
![fh-table-column-options](/uploads/951039e00889a78d3dafbce5132e1f2d/fh-table-column-options.png)
It would be good to have an option to disable it.1.51TejeshTejeshhttps://code.gramener.com/cto/g1/-/issues/42formhandler table cell link is not urlencoded2019-03-01T04:00:22ZTejeshformhandler table cell link is not urlencoded### Summary
formhandler table cell link is not urlencoded
### Steps to reproduce
g1 version 0.6.0
visit https://uat.gramener.com/fdd/#?SEGMENT=M%26M and click on Segment column value `M&M`. Filtering fails because `&` in `M&M` is not...### Summary
formhandler table cell link is not urlencoded
### Steps to reproduce
g1 version 0.6.0
visit https://uat.gramener.com/fdd/#?SEGMENT=M%26M and click on Segment column value `M&M`. Filtering fails because `&` in `M&M` is not urlencoded
### Possible fixes
Need to add a test case and verify the issue. Expected behavior of current code is urlencoded string but that's not the case.1.51S AnandS Anandhttps://code.gramener.com/cto/g1/-/issues/85FormHandler table should support client-side validation2019-02-27T06:35:44ZS AnandFormHandler table should support client-side validationRaised by @sarad.gurram and @bhanu.k - "Client-side HTML input validation while editing"Raised by @sarad.gurram and @bhanu.k - "Client-side HTML input validation while editing"1.52S AnandS Anandhttps://code.gramener.com/cto/g1/-/issues/75formhandler: should support multiple sort2019-02-25T12:57:25ZPratap Vardhanpratap.vardhan@gramener.comformhandler: should support multiple sort### Summary
Currently, from the interface, user can select only column to sort on. However Gramex FormHandler supports multiple column sort by Column order.
For example, this https://learn.gramener.com/guide/formhandler/table.html#?_so...### Summary
Currently, from the interface, user can select only column to sort on. However Gramex FormHandler supports multiple column sort by Column order.
For example, this https://learn.gramener.com/guide/formhandler/table.html#?_sort=Continent&_sort=Name
- Would show two column sort on Name, Continent
- although it doesn't highlight the columns.
- If you try to add or modify existing sort. It get's replaced by single sort.
We would need a way to support muli-column sort, if we also want to support toggle between columns for single sort.1.52Pratap Vardhanpratap.vardhan@gramener.comPratap Vardhanpratap.vardhan@gramener.comhttps://code.gramener.com/cto/g1/-/issues/156BUG: In editable formhandler, select tag doesnt take default values if src da...2019-03-17T02:45:25ZTejeshBUG: In editable formhandler, select tag doesnt take default values if src data contains boolean values1.53TejeshTejeshhttps://code.gramener.com/cto/g1/-/issues/176add a new row with empty data for g1.formhandler2019-12-05T11:15:48ZPratap Vardhanpratap.vardhan@gramener.comadd a new row with empty data for g1.formhandler### Summary
We can't add a new row with empty data for g1.formhandler
### Steps to reproduce
- Create a csv with columns alone and hook it up with formhandler### Summary
We can't add a new row with empty data for g1.formhandler
### Steps to reproduce
- Create a csv with columns alone and hook it up with formhandlerhttps://code.gramener.com/cto/g1/-/issues/164Unable to deselect the selected sorted option2019-05-08T02:28:37ZAkash BarlaUnable to deselect the selected sorted option![sort_deselect](/uploads/a7bd6a42973c618f863c80da2cc68eb5/sort_deselect.gif)![sort_deselect](/uploads/a7bd6a42973c618f863c80da2cc68eb5/sort_deselect.gif)TejeshTejeshhttps://code.gramener.com/cto/g1/-/issues/163Column filter is displaying multiple times in header when we hide the filter2019-05-08T02:28:28ZAkash BarlaColumn filter is displaying multiple times in header when we hide the filter![Column_hiding_issue](/uploads/5876b231e885375373c38129a3ed27fe/Column_hiding_issue.gif)![Column_hiding_issue](/uploads/5876b231e885375373c38129a3ed27fe/Column_hiding_issue.gif)TejeshTejeshhttps://code.gramener.com/cto/g1/-/issues/161g1.formhandler refactor2019-05-08T02:28:20ZTejeshg1.formhandler refactor1. define hierarchy of hooks, make sure it is consistent
2. Examples & documentation
3. Refactor to develop faster1. define hierarchy of hooks, make sure it is consistent
2. Examples & documentation
3. Refactor to develop fasterTejeshTejeshhttps://code.gramener.com/cto/g1/-/issues/157Formhandler Excel export options must enable downloading of entire dataset2019-03-12T05:50:13ZTejeshFormhandler Excel export options must enable downloading of entire datasetraised by @anvesh.dasariraised by @anvesh.dasarihttps://code.gramener.com/cto/g1/-/issues/155Formhandler - show _count, _limit, _offset also as filters.2019-03-04T03:51:04ZTejeshFormhandler - show _count, _limit, _offset also as filters.On changing pageSize, there is no way to clear the filter. Showing `_limit=` also in filters will help.
Same problem when applied filter `"Europe"`, goto page 2 and clear `"Europe"` filter.....Still shows _offset=1, no way to clear the ...On changing pageSize, there is no way to clear the filter. Showing `_limit=` also in filters will help.
Same problem when applied filter `"Europe"`, goto page 2 and clear `"Europe"` filter.....Still shows _offset=1, no way to clear the filter.
Other solution is to, On click of "clear all filters", remove `_offset=`https://code.gramener.com/cto/g1/-/issues/151g1.formhandler unique value filtering - handling more than 100 unique values ...2019-02-19T13:53:12ZTejeshg1.formhandler unique value filtering - handling more than 100 unique values per column- If there are more than limit: values (default: 100), show up to limit items. Mention that "Only first {limit} items shown"- If there are more than limit: values (default: 100), show up to limit items. Mention that "Only first {limit} items shown"